Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CI in PRs that target feat/... branches #1487

Conversation

wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Dec 6, 2024

Description of change

Add support for CI in PRs that target feat/... branches, and removes CI triggers for epic/... branches (currently unused).

The audit workflow has been enabled for support/... targeting PRs as well. Summary of changes:

workflow change
audit + feat/**
+ support/**
build-and-test-grpc * epic/** -> feat/**
build-and-test * epic/** -> feat/**
clippy * epic/** -> feat/**
format * epic/** -> feat/**

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix
  • CI

How the change has been tested

Checked format, etc. locally, PR's CI should be triggered when openening this PR.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- run for feat/ targets
- don't run for epic/ targets (unused atm)
@wulfraem wulfraem added the No changelog Excludes PR from becoming part of any changelog label Dec 6, 2024
@wulfraem wulfraem requested a review from a team as a code owner December 6, 2024 10:13
@UMR1352 UMR1352 added the Chore Tedious, typically non-functional change label Dec 6, 2024
@wulfraem wulfraem merged commit 43aae13 into feat/identity-rebased-alpha Dec 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants