Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC build in CI #1457

Merged
merged 4 commits into from
Nov 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert ubuntu change for gRPC and add libssl-dev install to Dockerfile
wulfraem committed Nov 27, 2024
commit 3488e7688e05ed09938b360d3370c7deb6c22fab
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test-grpc.yml
Original file line number Diff line number Diff line change
@@ -19,15 +19,15 @@ on:

jobs:
check-for-run-condition:
runs-on: ubuntu-24.04
runs-on: ubuntu-latest
outputs:
should-run: ${{ !github.event.pull_request || github.event.pull_request.draft == false }}
steps:
- run: |
# this run step does nothing, but is needed to get the job output

build-and-test:
runs-on: ubuntu-24.04
runs-on: ubuntu-latest
steps:
- name: Check out the repo
uses: actions/checkout@v4
2 changes: 1 addition & 1 deletion .github/workflows/grpc-publish-to-dockerhub.yml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ jobs:
push_to_registry:
environment: release
name: Push Docker image to Docker Hub
runs-on: ubuntu-24.04
runs-on: ubuntu-latest
steps:
- name: Check out the repo
uses: actions/checkout@v4
6 changes: 5 additions & 1 deletion bindings/grpc/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
FROM rust:bookworm as builder

# update packages
RUN apt-get update
# install protobuf
RUN apt-get update && apt-get install -y protobuf-compiler libprotobuf-dev musl-tools
RUN apt-get install -y protobuf-compiler libprotobuf-dev musl-tools
# install openssl dev dependencies
RUN apt-get install -y libssl-dev

COPY . /usr/src/app/
WORKDIR /usr/src/app/bindings/grpc