Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clippy and fmt fixes and compilation error fix #1452

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

itsyaasir
Copy link
Contributor

@itsyaasir itsyaasir commented Nov 27, 2024

Description of change

This pull request includes several updates to the GitHub Actions workflow, improvements to the Rust codebase, and minor changes to dependencies and formatting. The most important changes are grouped by theme below:

General

  • Compilation fixes for the identity_storage crate.
  • Compilation fixes when building with non-default features

GitHub Actions Workflow Updates:

  • Updated the platform-specific asset pattern and download URL handling in the iota-rebase-sandbox setup action (.github/actions/iota-rebase-sandbox/setup/action.yml).
  • Changed the OS version from ubuntu-latest to ubuntu-24.04 in multiple workflow files to ensure compatibility with the iota binaries

Dependency Updates:

  • Updated the secret-storage dependency to use a specific tag version instead of the main branch in identity_iota_core/Cargo.toml.
  • Added lazy_static to use instead of LazyLock which was messing with the Rust min version.

Code Refactoring:

  • Changed the visibility of the client_document module from pub to mod and couple of clippy fixes

Feature Flag Adjustments:

  • Adjusted the feature flag from client to resolver for the DidResolutionHandler in the identity_iota/src/lib.rs.

These changes collectively improve the compatibility, readability, and maintainability of the codebase.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@itsyaasir itsyaasir added Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog labels Nov 27, 2024
@itsyaasir itsyaasir self-assigned this Nov 27, 2024
@itsyaasir itsyaasir requested a review from a team as a code owner November 27, 2024 05:40
@itsyaasir itsyaasir changed the title chore: clippy and fmt fixes chore: clippy and fmt fixes and compilation error fix Nov 27, 2024
@itsyaasir itsyaasir added Bug Something isn't working. and removed Chore Tedious, typically non-functional change labels Nov 27, 2024
@itsyaasir itsyaasir force-pushed the chore/clippy-fmt-fixes branch from 4041ca7 to 49d9b22 Compare November 27, 2024 06:28
@itsyaasir itsyaasir changed the base branch from main to feat/identity-rebased-alpha November 27, 2024 07:46
@wulfraem
Copy link
Contributor

Very happy to see the warnings disappear! :D

Was just wondering about the checks here:

  • Should we add RUSTSEC-2023-0071 to the audit.toml, as it's neither fixed nor a dependency we are really having control over.
  • Should we skip Wasm clippy check for now (e.g. if: ${{ false }} or something) due to the current in progress state of the wasm part?

@itsyaasir
Copy link
Contributor Author

itsyaasir commented Nov 27, 2024

Yes! @wulfraem I agree as well; had the idea to skip all wasm tests and checks. Let me update it.

@UMR1352
Copy link
Contributor

UMR1352 commented Nov 27, 2024

Great job Yasir! Do you mind if we merge this for last? I fear that all other open PR will interfere with your changes somehow resulting in having to redo this again

@UMR1352
Copy link
Contributor

UMR1352 commented Nov 27, 2024

Fixed some conflicts due to my latest PRs

@itsyaasir
Copy link
Contributor Author

Fixed some conflicts due to my latest PRs

Eii Thanks man!

@itsyaasir itsyaasir merged commit aeb680a into feat/identity-rebased-alpha Nov 27, 2024
1 check passed
@itsyaasir itsyaasir deleted the chore/clippy-fmt-fixes branch November 27, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants