-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clippy and fmt fixes and compilation error fix #1452
Merged
itsyaasir
merged 3 commits into
feat/identity-rebased-alpha
from
chore/clippy-fmt-fixes
Nov 27, 2024
Merged
chore: clippy and fmt fixes and compilation error fix #1452
itsyaasir
merged 3 commits into
feat/identity-rebased-alpha
from
chore/clippy-fmt-fixes
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsyaasir
added
Chore
Tedious, typically non-functional change
No changelog
Excludes PR from becoming part of any changelog
labels
Nov 27, 2024
itsyaasir
changed the title
chore: clippy and fmt fixes
chore: clippy and fmt fixes and compilation error fix
Nov 27, 2024
itsyaasir
added
Bug
Something isn't working.
and removed
Chore
Tedious, typically non-functional change
labels
Nov 27, 2024
itsyaasir
force-pushed
the
chore/clippy-fmt-fixes
branch
from
November 27, 2024 06:28
4041ca7
to
49d9b22
Compare
Very happy to see the warnings disappear! :D Was just wondering about the checks here:
|
Yes! @wulfraem I agree as well; had the idea to skip all wasm tests and checks. Let me update it. |
wulfraem
approved these changes
Nov 27, 2024
Great job Yasir! Do you mind if we merge this for last? I fear that all other open PR will interfere with your changes somehow resulting in having to redo this again |
Fixed some conflicts due to my latest PRs |
UMR1352
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This pull request includes several updates to the GitHub Actions workflow, improvements to the Rust codebase, and minor changes to dependencies and formatting. The most important changes are grouped by theme below:
General
identity_storage
crate.GitHub Actions Workflow Updates:
iota-rebase-sandbox
setup action (.github/actions/iota-rebase-sandbox/setup/action.yml
).ubuntu-latest
toubuntu-24.04
in multiple workflow files to ensure compatibility with the iota binariesDependency Updates:
secret-storage
dependency to use a specific tag version instead of the main branch inidentity_iota_core/Cargo.toml
.lazy_static
to use instead ofLazyLock
which was messing with the Rust min version.Code Refactoring:
client_document
module frompub
tomod
and couple of clippy fixesFeature Flag Adjustments:
client
toresolver
for theDidResolutionHandler
in theidentity_iota/src/lib.rs
.These changes collectively improve the compatibility, readability, and maintainability of the codebase.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #
.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
x
to the boxes that are relevant to your changes.