Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable legacy Firefox CDP support #1403

Merged
merged 3 commits into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ jobs:
load: true

- name: Run cypress
run: docker run --network host cypress-test test:browser:firefox
run: docker run --network host cypress-test test:browser:parallel:firefox

- name: Tear down iota sandbox
if: always()
Expand Down
10 changes: 8 additions & 2 deletions bindings/wasm/cypress.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,20 @@ export default defineConfig({
},
e2e: {
supportFile: false,
// Fix to make subtle crypto work in cypress firefox
// https://github.com/cypress-io/cypress/issues/18217
setupNodeEvents(on, config) {
on("before:browser:launch", (browser, launchOptions) => {
if (browser.family === "firefox") {
// Fix to make subtle crypto work in cypress firefox
// https://github.com/cypress-io/cypress/issues/18217
launchOptions.preferences[
"network.proxy.testing_localhost_is_secure_when_hijacked"
] = true;
// Temporary fix to allow cypress to control Firefox via CDP
// https://github.com/cypress-io/cypress/issues/29713
// https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/
launchOptions.preferences[
"remote.active-protocols"
] = 3;
}
return launchOptions;
});
Expand Down
Loading