Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WASM bindings for EcDSA JWS Verifier #1396

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Add WASM bindings for EcDSA JWS Verifier #1396

merged 7 commits into from
Sep 5, 2024

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Aug 20, 2024 •
edited
Loading

Description of change

Provides WASM bindings for EcDSA JWS verifier.
Provides a fall back JWS verifier that handles ED25519, ES256, ES256K signatures whenever a custom verifier isn't provided.

Closes #1395

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@UMR1352 UMR1352 added Documentation Improvements or additions to documentation. Excludes from changelog Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Added A new feature that requires a minor release. Part of "Added" section in changelog labels Aug 20, 2024
@UMR1352 UMR1352 self-assigned this Aug 20, 2024
@UMR1352 UMR1352 requested a review from a team as a code owner August 20, 2024 08:36
@eike-hass eike-hass requested a review from wulfraem August 20, 2024 08:38
@eike-hass eike-hass changed the title [Feat] Add WASM bindings for EcDSA JWS Verifier Add WASM bindings for EcDSA JWS Verifier Sep 2, 2024
@UMR1352 UMR1352 requested a review from a team September 4, 2024 07:23
@UMR1352 UMR1352 merged commit ba36609 into main Sep 5, 2024
13 checks passed
@UMR1352 UMR1352 deleted the feat/ecdsa-verifier-wasm branch September 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qrayven qrayven qrayven approved these changes

@itsyaasir itsyaasir itsyaasir approved these changes

@wulfraem wulfraem wulfraem approved these changes

Assignees

@UMR1352 UMR1352

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Documentation Improvements or additions to documentation. Excludes from changelog Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add WASM bindings for identity_ecdsa_verifier
4 participants
@UMR1352 @wulfraem @itsyaasir @qrayven