Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grpc): enhance domain grpc services #1381

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

itsyaasir
Copy link
Contributor

@itsyaasir itsyaasir commented Jun 18, 2024

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@itsyaasir itsyaasir self-assigned this Jun 18, 2024
@itsyaasir itsyaasir added Enhancement New feature or improvement to an existing feature gRPC Related to the gRPC bindings code Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jun 19, 2024
@itsyaasir itsyaasir marked this pull request as ready for review June 19, 2024 13:58
@itsyaasir itsyaasir requested a review from a team as a code owner June 19, 2024 13:58
@itsyaasir itsyaasir added the Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog label Jun 19, 2024
@eike-hass eike-hass added No changelog Excludes PR from becoming part of any changelog and removed Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Jun 19, 2024
Copy link
Contributor

@UMR1352 UMR1352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Do we really care about the order in which domains are validated? If that's not the case let's validate them parallely

bindings/grpc/proto/domain_linkage.proto Outdated Show resolved Hide resolved
bindings/grpc/proto/domain_linkage.proto Show resolved Hide resolved
bindings/grpc/src/services/domain_linkage.rs Outdated Show resolved Hide resolved
examples/1_advanced/6_domain_linkage.rs Outdated Show resolved Hide resolved
@itsyaasir itsyaasir requested a review from wulfraem June 20, 2024 11:40
@itsyaasir itsyaasir linked an issue Jun 21, 2024 that may be closed by this pull request
9 tasks
@eike-hass eike-hass merged commit 2af02da into main Jun 21, 2024
26 of 27 checks passed
@eike-hass eike-hass deleted the feat/ehance-domain-grpc-service branch June 21, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to an existing feature gRPC Related to the gRPC bindings code No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Improve Domain Linkage gRPC service
4 participants