-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(grpc): enhance domain grpc services #1381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsyaasir
added
Enhancement
New feature or improvement to an existing feature
gRPC
Related to the gRPC bindings code
Chore
Tedious, typically non-functional change
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
Jun 19, 2024
itsyaasir
added
the
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
label
Jun 19, 2024
eike-hass
added
No changelog
Excludes PR from becoming part of any changelog
and removed
Chore
Tedious, typically non-functional change
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
labels
Jun 19, 2024
UMR1352
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Do we really care about the order in which domains are validated? If that's not the case let's validate them parallely
wulfraem
requested changes
Jun 20, 2024
eike-hass
approved these changes
Jun 20, 2024
wulfraem
approved these changes
Jun 21, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
New feature or improvement to an existing feature
gRPC
Related to the gRPC bindings code
No changelog
Excludes PR from becoming part of any changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #
.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
x
to the boxes that are relevant to your changes.