-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin and bump bls12_381_plus
dependency
#1378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wulfraem
added
Bug
Something isn't working.
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
Jun 11, 2024
wulfraem
added
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
and removed
Bug
Something isn't working.
labels
Jun 11, 2024
- additional crates that use `zkryptium` - crates that use `json-proof-token`
frederikrothenberger
pushed a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Jun 12, 2024
In preparation of moving `vc_util` to this repository, the following changes are made: * switch to DFINITY iota fork * adjust alias parsing to new library * move issuer dependencies to workspace Cargo.toml * pin bls12_381_plus as a workaround for iotaledger/identity.rs#1378
frederikrothenberger
pushed a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Jun 12, 2024
In preparation of moving `vc_util` to this repository, the following changes are made: * switch to DFINITY iota fork * adjust alias parsing to new library * move issuer dependencies to workspace Cargo.toml * pin bls12_381_plus as a workaround for iotaledger/identity.rs#1378
frederikrothenberger
pushed a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Jun 12, 2024
In preparation of moving `vc_util` to this repository, the following changes are made: * switch to DFINITY iota fork * adjust alias parsing to new library * move issuer dependencies to workspace Cargo.toml * pin bls12_381_plus as a workaround for iotaledger/identity.rs#1378
frederikrothenberger
pushed a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Jun 12, 2024
In preparation of moving `vc_util` to this repository, the following changes are made: * switch to DFINITY iota fork * adjust alias parsing to new library * move issuer dependencies to workspace Cargo.toml * pin bls12_381_plus as a workaround for iotaledger/identity.rs#1378
frederikrothenberger
pushed a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Jun 12, 2024
In preparation of moving `vc_util` to this repository, the following changes are made: * switch to DFINITY iota fork * adjust alias parsing to new library * move issuer dependencies to workspace Cargo.toml * pin bls12_381_plus as a workaround for iotaledger/identity.rs#1378
eike-hass
approved these changes
Jun 12, 2024
itsyaasir
approved these changes
Jun 12, 2024
frederikrothenberger
pushed a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Jun 12, 2024
In preparation of moving `vc_util` to this repository, the following changes are made: * switch to DFINITY iota fork * adjust alias parsing to new library * move issuer dependencies to workspace Cargo.toml * pin bls12_381_plus as a workaround for iotaledger/identity.rs#1378
frederikrothenberger
pushed a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Jun 12, 2024
In preparation of moving `vc_util` to this repository, the following changes are made: * switch to DFINITY iota fork * adjust alias parsing to new library * move issuer dependencies to workspace Cargo.toml * pin bls12_381_plus as a workaround for iotaledger/identity.rs#1378
frederikrothenberger
pushed a commit
to dfinity/identity.rs
that referenced
this pull request
Jun 12, 2024
frederikrothenberger
pushed a commit
to dfinity/identity.rs
that referenced
this pull request
Jun 12, 2024
Pin and bump `bls12_381_plus` dependency (iotaledger#1378)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The most recent version of
bls12_381_plus
introduces adds changes to type conversion that may break builds due to conflicting implementations ofFrom
trait.Pinning this dependency to the previous version hotfixes build issues when used as an indirect dependency here (via
zkryptium
).Version should be able to opened up in the future, but for now we should stick to the
0.8.15
.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
cargo clean
, deleting theCargo.lock
file, and runningcargo build
on the main branch produces the error described above. Doing the same on the PR's branch completes the build successfully.Change checklist
Add an
x
to the boxes that are relevant to your changes.