Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for specification-compliant verification method type JsonWebKey2020 #1367

Merged
merged 3 commits into from
May 24, 2024

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented May 21, 2024

Description of change

Support for JWK-based verification has long been added to the library but under a non-standardized type - i.e. JsonWebKey. This PR solves this issue by making the already implemented method spec-compliant by changing the method's type to JsonWebKey2020 and deprecating the previous type.

Links to any relevant issues

Closes #1366

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Ran linter and all tests.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@UMR1352 UMR1352 added Bug Something isn't working. Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels May 21, 2024
@UMR1352 UMR1352 self-assigned this May 21, 2024
@UMR1352 UMR1352 requested a review from a team as a code owner May 21, 2024 13:04
@eike-hass eike-hass self-requested a review May 23, 2024 14:45
@UMR1352 UMR1352 merged commit b634ead into main May 24, 2024
12 checks passed
@UMR1352 UMR1352 deleted the feat/json-web-key-2020 branch May 24, 2024 09:59
@eike-hass eike-hass added the Wasm Related to Wasm bindings. Becomes part of the Wasm changelog label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add JSONWebKey2020
3 participants