Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials cannot be unrevoked with StatusList2021 #1284

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Credentials cannot be unrevoked with StatusList2021 #1284

merged 7 commits into from
Jan 26, 2024

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Jan 26, 2024

Description of change

Fixed a "bug" that allows for revoked credentials to become valid again.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Added a unit test.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@UMR1352 UMR1352 self-assigned this Jan 26, 2024
@UMR1352 UMR1352 requested a review from a team as a code owner January 26, 2024 10:53
@UMR1352 UMR1352 added Bug Something isn't working. Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Jan 26, 2024
@UMR1352 UMR1352 merged commit a929510 into main Jan 26, 2024
10 checks passed
@UMR1352 UMR1352 deleted the fix/status-list-2021-make-credentials-unrevocable branch January 26, 2024 14:33
@eike-hass eike-hass linked an issue Jan 26, 2024 that may be closed by this pull request
[Task] Implement Status List 2021 #1277
Closed
8 tasks
@eike-hass eike-hass added the Wasm Related to Wasm bindings. Becomes part of the Wasm changelog label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulmth abdulmth abdulmth approved these changes

@eike-hass eike-hass eike-hass approved these changes

Assignees

@UMR1352 UMR1352

Labels
Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Implement Status List 2021
3 participants
@UMR1352 @eike-hass @abdulmth