Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1266

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Update README.md #1266

merged 1 commit into from
Nov 29, 2023

Conversation

l4rot
Copy link
Contributor

@l4rot l4rot commented Nov 28, 2023

added the memstore feature to the cargo.toml, since the example won't work without that activated.

Description of change

After trial and error periods and reinstalling my env I noticed that the memstore feature hasn't been added to the cargo.toml in the example, hence why it did not compile for me initially. added it to the readme to safe other people from having a headache over the same issue.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

The example project finally ran.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

added the memstore feature to the cargo.toml, since the example won't work without that activated.
Copy link
Contributor

@abdulmth abdulmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR.

@abdulmth abdulmth added the No changelog Excludes PR from becoming part of any changelog label Nov 29, 2023
@eike-hass eike-hass merged commit fcb4f11 into iotaledger:main Nov 29, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants