Fix wasm panic caused by a race condition in IotaDocument and CoreDocument
#1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
added
Bug
abdulmth
added
the
Patch
|
Great that you tackled this! It might be an idea to include a typescript test that asserts an error is thrown in the scenario described in this comment |
PhilippGackstatter
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Looks good to me. I think that's the most reasonable way to deal with this.
If I do a Promise.all on multiple promises each of which does a createJws (so an async read), that should be fine because it would use asynchronous rather than synchronous locking, right? That's how I understood #1150.
yes that's true. |
eike-hass
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fixes ##1150
This PR change the methods requiring read/write to be fallible if the lock is acquired to prevent uncontrolled crashes, since blocking is not supported for
RwLockin wasm.