Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo release #1252

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Update cargo release #1252

merged 2 commits into from
Jan 18, 2024

Conversation

eike-hass
Copy link
Collaborator

@eike-hass eike-hass commented Sep 29, 2023

Description of change

Update cargo release to potentially fix an issue with path dev-dependencies during release

relates to #1065

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Will need to be tested in CI
Note: This will likely break with our current crate structure so we need to reorganize it. Let's hope dry-run catches it 🤞

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass eike-hass added the No changelog Excludes PR from becoming part of any changelog label Sep 29, 2023
@eike-hass eike-hass requested review from abdulmth and UMR1352 January 18, 2024 12:00
@eike-hass eike-hass merged commit f372b35 into main Jan 18, 2024
9 checks passed
@eike-hass eike-hass deleted the chore/use-latest-cargo-release branch January 18, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants