Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom JWT claims for credentials #1237

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Allow custom JWT claims for credentials #1237

merged 5 commits into from
Sep 20, 2023

Conversation

abdulmth
Copy link
Contributor

No description provided.

@abdulmth abdulmth self-assigned this Sep 15, 2023
@abdulmth abdulmth added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Sep 15, 2023
@abdulmth abdulmth added this to the v1.0 Features milestone Sep 15, 2023
PhilippGackstatter
PhilippGackstatter approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, even though I wish there was a nicer way to facilitate these custom claims without polluting the API with something that is rarely going to be used by the average caller.

identity_storage/src/storage/jwk_document_ext.rs Show resolved Hide resolved
@abdulmth abdulmth requested a review from eike-hass September 20, 2023 08:57
@abdulmth abdulmth merged commit e429809 into main Sep 20, 2023
10 checks passed
@abdulmth abdulmth deleted the feat/custom-jwt-claims-for-credentials branch September 20, 2023 10:23
@abdulmth abdulmth mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippGackstatter PhilippGackstatter PhilippGackstatter approved these changes

@eike-hass eike-hass eike-hass approved these changes

Assignees

@abdulmth abdulmth

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
IOTA Identity - Framework Developments
Status: Done
Milestone
v1.0 Features
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulmth @eike-hass @PhilippGackstatter