review comments

iotaledger · Mar 14, 2024 · c42c50f · c42c50f
1 parent 84a5586
commit c42c50f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/bindings/wasm/src/verification/wasm_method_data.rs b/bindings/wasm/src/verification/wasm_method_data.rs
@@ -125,3 +125,6 @@ impl From<WasmCustomMethodData> for CustomMethodData {
     value.0
   }
 }
+
+impl_wasm_clone!(WasmCustomMethodData, CustomMethodData);
+impl_wasm_json!(WasmCustomMethodData, CustomMethodData);
diff --git a/identity_verification/src/verification_method/method.rs b/identity_verification/src/verification_method/method.rs
@@ -246,7 +246,9 @@ impl KeyComparable for VerificationMethod {
   }
 }
 
-// Horrible workaround for a tracked serde issue https://github.com/serde-rs/serde/issues/2200
+// Horrible workaround for a tracked serde issue https://github.com/serde-rs/serde/issues/2200. Serde doesn't "consume"
+// the input when deserializing flattened enums (MethodData in this case) cousing duplication of data (in this case 
+// it ends up in the properties object). This workaround simply remove the duplication.
 #[derive(Deserialize)]
 struct _VerificationMethod {
   #[serde(deserialize_with = "deserialize_id_with_fragment")]
-Original file line number
+Diff line change
@@ Expand Up / @@ -125,3 +125,6 @@ impl From<WasmCustomMethodData> for CustomMethodData { @@
         value.0
       }
     }
+    impl_wasm_clone!(WasmCustomMethodData, CustomMethodData);
+    impl_wasm_json!(WasmCustomMethodData, CustomMethodData);