Skip to content

Add EcDSA verifier #4397

Add EcDSA verifier

Add EcDSA verifier #4397

Re-run triggered May 7, 2024 14:27
Status Failure
Total duration 58s
Artifacts

clippy.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 2 warnings
bound is defined in more than one place: identity_jose/src/jwu/serde.rs#L27
error: bound is defined in more than one place --> identity_jose/src/jwu/serde.rs:27:45 | 27 | pub(crate) fn filter_non_empty_bytes<'a, T, U: 'a>(value: T) -> Option<&'a [u8]> | ^ ... 30 | U: AsRef<[u8]> + ?Sized, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `-D clippy::multiple-bound-locations` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::multiple_bound_locations)]`
you should consider adding a `Default` implementation for `JwkParamsEc`: identity_jose/src/jwk/key_params.rs#L108
error: you should consider adding a `Default` implementation for `JwkParamsEc` --> identity_jose/src/jwk/key_params.rs:108:3 | 108 | / pub const fn new() -> Self { 109 | | Self { 110 | | crv: String::new(), 111 | | x: String::new(), ... | 114 | | } 115 | | } | |___^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-D clippy::new-without-default` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::new_without_default)]` help: try adding this | 106 + impl Default for JwkParamsEc { 107 + fn default() -> Self { 108 + Self::new() 109 + } 110 + } |
you should consider adding a `Default` implementation for `JwkParamsRsa`: identity_jose/src/jwk/key_params.rs#L243
error: you should consider adding a `Default` implementation for `JwkParamsRsa` --> identity_jose/src/jwk/key_params.rs:243:3 | 243 | / pub const fn new() -> Self { 244 | | Self { 245 | | n: String::new(), 246 | | e: String::new(), ... | 254 | | } 255 | | } | |___^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try adding this | 241 + impl Default for JwkParamsRsa { 242 + fn default() -> Self { 243 + Self::new() 244 + } 245 + } |
you should consider adding a `Default` implementation for `JwkParamsOct`: identity_jose/src/jwk/key_params.rs#L325
error: you should consider adding a `Default` implementation for `JwkParamsOct` --> identity_jose/src/jwk/key_params.rs:325:3 | 325 | / pub const fn new() -> Self { 326 | | Self { k: String::new() } 327 | | } | |___^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try adding this | 323 + impl Default for JwkParamsOct { 324 + fn default() -> Self { 325 + Self::new() 326 + } 327 + } |
you should consider adding a `Default` implementation for `JwkParamsOkp`: identity_jose/src/jwk/key_params.rs#L374
error: you should consider adding a `Default` implementation for `JwkParamsOkp` --> identity_jose/src/jwk/key_params.rs:374:3 | 374 | / pub const fn new() -> Self { 375 | | Self { 376 | | crv: String::new(), 377 | | x: String::new(), 378 | | d: None, 379 | | } 380 | | } | |___^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try adding this | 372 + impl Default for JwkParamsOkp { 373 + fn default() -> Self { 374 + Self::new() 375 + } 376 + } |
you should consider adding a `Default` implementation for `JwtHeader`: identity_jose/src/jwt/header.rs#L110
error: you should consider adding a `Default` implementation for `JwtHeader` --> identity_jose/src/jwt/header.rs:110:3 | 110 | / pub const fn new() -> Self { 111 | | Self { 112 | | jku: None, 113 | | jwk: None, ... | 124 | | } 125 | | } | |___^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try adding this | 108 + impl Default for JwtHeader { 109 + fn default() -> Self { 110 + Self::new() 111 + } 112 + } |
clippy
Clippy had exited with the 101 exit code
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, jetli/wasm-bindgen-action@24ba6f9fff570246106ac3f80f35185600c3f6c9, actions-rs-plus/clippy-check@b09a9c37c9df7db8b1a5d52e8fe8e0b6e3d574c4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: jetli/wasm-bindgen-action@24ba6f9fff570246106ac3f80f35185600c3f6c9. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/