Skip to content

Fix links

Fix links #4144

Re-run triggered October 9, 2023 16:12
Status Failure
Total duration 3m 44s
Artifacts

clippy.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 1 warning
incorrect implementation of `partial_cmp` on an `Ord` type: identity_did/src/did_url.rs#L228
error: incorrect implementation of `partial_cmp` on an `Ord` type --> identity_did/src/did_url.rs:228:1 | 228 | / impl PartialOrd for RelativeDIDUrl { 229 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | ___________________________________________________________- 230 | || // Compare path, query, then fragment in that order 231 | || let path_cmp = self 232 | || .path ... || 257 | || Some(path_cmp) 258 | || } | ||___- help: change this to: `{ Some(self.cmp(other)) }` 259 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type = note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
incorrect implementation of `partial_cmp` on an `Ord` type: identity_did/src/did_url.rs#L479
error: incorrect implementation of `partial_cmp` on an `Ord` type --> identity_did/src/did_url.rs:479:1 | 479 | / impl PartialOrd for DIDUrl { 480 | | #[inline] 481 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | ___________________________________________________________- 482 | || match self.did().partial_cmp(other.did()) { 483 | || None => None, 484 | || Some(Ordering::Equal) => self.url().partial_cmp(other.url()), 485 | || Some(ord) => Some(ord), 486 | || } 487 | || } | ||___- help: change this to: `{ Some(self.cmp(other)) }` 488 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
clippy
Clippy had exited with the 101 exit code
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: jetli/wasm-bindgen-action@24ba6f9fff570246106ac3f80f35185600c3f6c9. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/