Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not suggest collecting if available funds < basic output min storage deposit or there arent enough outputs to consolidate #7609

Merged

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #7519
...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda changed the title feat: disable Collect button if not available funds or outputs feat: do not suggest collecting if available funds < basic output min storage deposit or there arent enough outputs to consolidate Oct 17, 2023
@evavirseda evavirseda requested a review from cpl121 October 19, 2023 08:37
@evavirseda evavirseda requested a review from cpl121 October 20, 2023 06:39
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🚀

Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seams to be an issue with areOutputsReadyForConsolidation.
If user navigates back and forward(without collecting) to Vesting tab first time prepareConsolidateOutputs returns true and second time it returns an error that there are no outputs to consolidate and Collect button is disabled.
Screencast from 25.10.2023 10:17:02.webm

Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NJ

Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit f405fd2 into develop Oct 30, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/avoid-collecting-if-not-available-funds-or-outputs branch October 30, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants