Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial loading spinner not centered (for suspense fallback) #1422

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

panteleymonchuk
Copy link
Collaborator

@panteleymonchuk panteleymonchuk commented Apr 22, 2024

Description of change

Close #1452

Change position of spinner from top-left corner to center (for Suspense fallback)
It's a small update. We don't need opened issue for that.

Before
image

After
image

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base branch should be main not dev 🙏🏼

@begonaalvarezd begonaalvarezd linked an issue Apr 25, 2024 that may be closed by this pull request
@panteleymonchuk panteleymonchuk force-pushed the feat/change-position-of-initial-loader branch from f1e44a0 to c4155cf Compare April 25, 2024 13:28
@panteleymonchuk panteleymonchuk changed the base branch from dev to main April 25, 2024 13:28
@begonaalvarezd begonaalvarezd changed the title Change position of init loader (for Suspense fallback). fix: initial loading spinner not centered (for suspense fallback) Apr 25, 2024
@begonaalvarezd begonaalvarezd merged commit 33f058f into main Apr 25, 2024
6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/change-position-of-initial-loader branch April 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix initial loading spinner not centered
2 participants