-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ed25519 public key bytes wrapper #221
Add ed25519 public key bytes wrapper #221
Conversation
What is the purpose of such wrapper? In which way the wrapper "does not require validation"? In my opinion, it adds extra code duplication without clear benefits. Could you please provide a non-trivial use-case example demonstrating benefits of the wrapper? |
It does not require validation of bytes for the type to be constructed, unlike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description of change
This PR adds a public key bytes wrapper that does not require validation to exist.
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Modified a few existing tests to use the new type.
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.