-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refacto(air/layout): move compute_program_hash in utils.rs #59
base: main
Are you sure you want to change the base?
Conversation
I think that better idea is to not create another file lets move this function to mod.rs there are some common utils there already so it fits in imo |
61e4e5d
to
92d9957
Compare
@Okm165 done Sidenote: more than half of this file is Error definition. Maybe moving those into their own error.rs could make sense |
92d9957
to
d057818
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
write comment here when u finalized everything i will merge
@Okm165 I moved the errors to their own file. Btw, is there a reason why you prefer to duplicate the error structs and use both |
@tdelabro No particular reason |
@Okm165 I will on a separated PR as it spans changes across multiple crates |
Tell me if it's fine for it to leave in utils.rs