Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

final_pc check #56

Merged
merged 3 commits into from
Dec 20, 2024
Merged

final_pc check #56

merged 3 commits into from
Dec 20, 2024

Conversation

Okm165
Copy link
Contributor

@Okm165 Okm165 commented Dec 18, 2024 •
edited
Loading

This PR removes final_pc check from public memory validation
The check verified initial_pc + 4 = final_pc and it is satisfied when python-vm is used
When the program is ran in cairo-vm the memory layout is different and the check is no longer satisfied
This change is not modifying STARK verifying logic

@Okm165 Okm165 changed the base branch from main to dynamic_params/fixed_type December 18, 2024 16:34
@Okm165 Okm165 mentioned this pull request Dec 18, 2024
Closed
@Okm165 Okm165 linked an issue Dec 18, 2024 that may be closed by this pull request
crates/stark/src/oods.rs:31:18: attempt to subtract with overflow #55
Closed
@Okm165 Okm165 self-assigned this Dec 18, 2024
@Okm165 Okm165 added the bug Something isn't working label Dec 18, 2024
Base automatically changed from dynamic_params/fixed_type to main December 19, 2024 07:19
@Okm165 Okm165 merged commit b519849 into main Dec 20, 2024
18 checks passed
@Okm165 Okm165 deleted the fix/final_pc branch December 20, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Okm165 Okm165

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crates/stark/src/oods.rs:31:18: attempt to subtract with overflow
1 participant
@Okm165