Refactor mbon stats #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
force-pushed
the
refactor_mbon_stats
branch
from
4593d43
to
6721f42
Compare
|
@MathewBiddle we need to merge #80 first and I'd like to ask you a few clarifications before moving forward with this one. So far all I did was to reduce the amount for for-loops but the data changed in subtle ways that I'm not sure they are related to the code change. I believe it may due too the time of the query. |
ocefpaf
force-pushed
the
refactor_mbon_stats
branch
from
6721f42
to
8c15d10
Compare
ocefpaf
force-pushed
the
refactor_mbon_stats
branch
from
8c15d10
to
807f140
Compare
|
Where does this stand? Is there more work to be done before a review? |
|
Let's close and reopen to toggle the CIs. If it still pass, I'd like to check if the changed data is expected, due to a later run, or if my changes are responsible for it. Hard for me to say b/c I'm not familiar with MBON. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start addressing #79