Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR - Add testing for dtype of glider df #85

Closed
wants to merge 4 commits into from

Conversation

celestinelindarto
Copy link

@celestinelindarto celestinelindarto commented Feb 28, 2024

Hi @ocefpaf,

I've had a go at forking the gliderpy repository and tried adding a testing method to check if the dtype of the glider df meets our expectations. This draft pull request contains changes in the test_fetchers.py file.

Let me know what you think of the changes.

Thank you.

Note: There are several errors with the checks - I'll try looking into this and give you an update.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 11, 2024

@celestinelindarto some dtype checking is nice but that should be done by trying to conform the fetched data and not at the test phase. We want the fetch code to error out if the columns are not in the dtype we expect.

We can work on this and more when the GSoC results are in. I'm closing this for now to avoid confusion.

@ocefpaf ocefpaf closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants