-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test_plotting in tests #107
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e732a1
Adding test_plotting in tests
FloraSauerbronn 7637063
updating requirements-dev with pytest
FloraSauerbronn b7191b5
Add new folder with base images for test_plotting
FloraSauerbronn b731bb7
Applying corrections to test_plotty.py
FloraSauerbronn 291c4f9
Updating tests.yml with pytest
FloraSauerbronn 4772432
Undoing changes for test failure
FloraSauerbronn fe3a51c
regenerate image
ocefpaf 4eb5f37
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ pyarrow | |
pytest | ||
pytest-cov | ||
pytest-flake8 | ||
pytest-mpl | ||
pytest-sugar | ||
pytest-xdist | ||
setuptools_scm | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,23 @@ | ||||||||||
"""Test transect.""" | ||||||||||
|
||||||||||
from pathlib import Path | ||||||||||
|
||||||||||
import pytest | ||||||||||
|
||||||||||
from gliderpy.fetchers import GliderDataFetcher | ||||||||||
from gliderpy.plotting import plot_transect | ||||||||||
|
||||||||||
root = Path(__file__).parent | ||||||||||
|
||||||||||
|
||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use this to get the current directory to build the path to the baseline directory, where the images for the comparisons are held.
Suggested change
|
||||||||||
@pytest.mark.mpl_image_compare(baseline_dir=root.joinpath("baseline/")) | ||||||||||
def test_plot_transect(): | ||||||||||
glider_grab = GliderDataFetcher() | ||||||||||
|
||||||||||
glider_grab.fetcher.dataset_id = "whoi_406-20160902T1700" | ||||||||||
df = glider_grab.to_pandas() | ||||||||||
# Generate the plot | ||||||||||
fig, ax = plot_transect(df, "temperature") | ||||||||||
|
||||||||||
# Return the figure for pytest-mpl to compare | ||||||||||
return fig |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using figures in tests we do not want matplotlib to fire up its Graphical User Interface (GUI) to avoid holding up the tests with a Window waiting to be closed.