add kafka cluster resource operations #465
Conversation
|
|
nice work 👍 let's add some bats tests for this |
| return []string{"AVAILABLE", "BUSY", "DEPLOYING", "UPDATING", "FAILED_UPDATING", "FAILED", "DESTROYING"}, cobra.ShellCompDirectiveNoFileComp | ||
| }) | ||
|
|
||
| cmd.AddStringFlag(constants.FlagLocation, "", "", "The datacenter location", core.RequiredFlagOption()) |
There was a problem hiding this comment.
If I want to list clusters across all locations, I have to make multiple lists with multiple locations, right?
| cmd.AddStringFlag(constants.FlagFilterName, "", "", "Filter used to fetch only the records that contain specified name.") | ||
| cmd.AddSetFlag(constants.FlagFilterState, "", "", []string{"AVAILABLE", "BUSY", "DEPLOYING", "UPDATING", "FAILED_UPDATING", "FAILED", "DESTROYING"}, "Filter used to fetch only the records that contain specified state.") | ||
| _ = cmd.Command.RegisterFlagCompletionFunc(constants.FlagFilterState, func(c *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | ||
| return []string{"AVAILABLE", "BUSY", "DEPLOYING", "UPDATING", "FAILED_UPDATING", "FAILED", "DESTROYING"}, cobra.ShellCompDirectiveNoFileComp |
There was a problem hiding this comment.
You don't need to add completions for Set type flags, they're added automatically
| return []string{"XS", "S", "M", "L", "XL"}, cobra.ShellCompDirectiveNoFileComp | ||
| }) | ||
|
|
||
| cmd.AddStringFlag(constants.FlagLocation, "", "", "The location of the kafka cluster", core.RequiredFlagOption()) |
There was a problem hiding this comment.
Could we add this as a persistent flag on the kafka command? instead of having it on each command
Also, some users can't use completions due to the nature of their environment so we should add the possible values to the helptext of the flag
slices.Collect(maps.Keys(locationToURL))
| Short: "The sub-commands of 'ionosctl kafka cluster' allow you to manage kafka clusters", | ||
| Aliases: []string{"cl"}, | ||
| TraverseChildren: true, | ||
| }, |
There was a problem hiding this comment.
| }, | |
| PersistentPreRun: func(cmd *cobra.Command, args []string) { | |
| location, _ := cmd.Flags().GetString(constants.FlagLocation) | |
| changeLocation(client.Must().KafkaClient, location) | |
| }, |
after moving Lcation as a PersistentFlag on this command
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)