fix(sfu): Fix ice logs (#366)

ionorg · Jan 5, 2021 · f7c0f63 · f7c0f63
1 parent 457db65
commit f7c0f63
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/pkg/sfu/peer.go b/pkg/sfu/peer.go
@@ -104,7 +104,7 @@ func (p *Peer) Join(sid string, sdp webrtc.SessionDescription) (*webrtc.SessionD
 	})
 
 	p.subscriber.OnICECandidate(func(c *webrtc.ICECandidate) {
-		log.Debugf("on ice candidate called")
+		log.Debugf("on subscriber ice candidate called for peer " + p.id)
 		if c == nil {
 			return
 		}
@@ -116,7 +116,7 @@ func (p *Peer) Join(sid string, sdp webrtc.SessionDescription) (*webrtc.SessionD
 	})
 
 	p.publisher.OnICECandidate(func(c *webrtc.ICECandidate) {
-		log.Debugf("on ice candidate called")
+		log.Debugf("on publisher ice candidate called for peer " + p.id)
 		if c == nil {
 			return
 		}

diff --git a/pkg/sfu/publisher.go b/pkg/sfu/publisher.go
@@ -84,7 +84,9 @@ func (p *Publisher) Answer(offer webrtc.SessionDescription) (webrtc.SessionDescr
 	}
 
 	for _, c := range p.candidates {
-		p.pc.AddICECandidate(c)
+		if err := p.pc.AddICECandidate(c); err != nil {
+			log.Errorf("Add publisher ice candidate to peer %s err: %v", p.id, err)
+		}
 	}
 	p.candidates = nil
 

diff --git a/pkg/sfu/subscriber.go b/pkg/sfu/subscriber.go
@@ -153,7 +153,9 @@ func (s *Subscriber) SetRemoteDescription(desc webrtc.SessionDescription) error
 	}
 
 	for _, c := range s.candidates {
-		s.pc.AddICECandidate(c)
+		if err := s.pc.AddICECandidate(c); err != nil {
+			log.Errorf("Add subscriber ice candidate to peer %s err: %v", s.id, err)
+		}
 	}
 	s.candidates = nil