Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't offer to reference the target project when adding a project reference #1945

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Oct 7, 2023

WHAT

🤖 Generated by Copilot at becb165

Fixed a bug and improved the user experience for adding project references in FsProjEdit.fs. Filtered out the current project and handled None paths in addProjectReferencePath.

🤖 Generated by Copilot at becb165

addProjectReferencePath
Filters out self, handles None
Autumn bug fixing

🐛🚸🔧

WHY

Don't offer people a rope.

HOW

🤖 Generated by Copilot at becb165

  • Fix a bug that allowed adding a circular reference to the same project and improve the user experience by showing only relevant options (link)

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@TheAngryByrd TheAngryByrd merged commit af178a5 into ionide:main Oct 7, 2023
3 checks passed
@dawedawe dawedawe deleted the no_circle branch October 7, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants