This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
Leave 20px for iOS status bar background. Fix selector for view caching. #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where the header bar shrinks the whole 64px rather than 44 on iOS and does not leave a background for the status bar (because the status bar overlays the web view). I realize you can use
StatusBar.overlaysWebView(false)
but this results in unnecessary real estate in the header bar. If you watch the video in this article on devdactic Shrinking Headers Like Facebook With the Ionic Framework you will notice the extra space in the header bar and it looks funky.I also removed the
shrink function
at the top because it is not being used anywhere in the directive.