Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): dismiss keyboard on drag card modal #30020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hedinasr
Copy link

Issue number: resolves #30019


What is the current behavior?

Dragging a card modal on iOS while the keyboard is open does not close the keyboard.

What is the new behavior?

Dragging a card modal closes the keyboard.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Before After
ScreenRecording_11-14-2024.13-51-10_1.mov
Simulator.Screen.Recording.-.iPhone.16.-.2024-11-14.at.14.54.03.mp4

@hedinasr hedinasr requested a review from a team as a code owner November 14, 2024 14:18
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 2:20pm

@aeharding
Copy link
Contributor

This is a breaking change for my use case, where users desire the keyboard to remain present.

A better solution would be adding onDragStart event to modal so developers can customize behavior - see: #23955 (comment)

@hedinasr
Copy link
Author

@aeharding actually, this is exactly the same behavior as the sheet modal; which closes the keyboard on drag. Can you show me an example of your use case?

@aeharding
Copy link
Contributor

@aeharding actually, this is exactly the same behavior as the sheet modal; which closes the keyboard on drag. Can you show me an example of your use case?

For example, iOS mail, if you pull down an email slightly the keyboard stays visible.

@hedinasr
Copy link
Author

hedinasr commented Nov 18, 2024

@aeharding do you think that we can add a prop to conditionally activate this feature? Like having a dimissKeyboard boolean prop? I can implement the feature here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug[ios]: open keyboard is not dismissed when card modal is dragged
2 participants