Merge pull request #39 from invrs-io/nb

Tweak loss plots
invrs-io · Oct 27, 2023 · 11338ec · 11338ec
2 parents aa3919b + 165370f
commit 11338ec
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/notebooks/ceviche_challenge.ipynb b/notebooks/ceviche_challenge.ipynb
@@ -87,7 +87,7 @@
     "plt.ylabel(\"Loss value\")\n",
     "plt.subplot(122)\n",
     "plt.plot(step, distance_to_target)\n",
-    "plt.plot(step[mask], distance_to_target[mask], \"bo-\")\n",
+    "plt.plot(step[mask], distance_to_target[mask], \"bo\")\n",
     "plt.xlabel(\"Step\")\n",
     "plt.ylabel(\"Distance to target\")\n",
     "\n",

diff --git a/notebooks/diffractive_splitter_challenge.ipynb b/notebooks/diffractive_splitter_challenge.ipynb
@@ -90,7 +90,7 @@
     "plt.ylabel(\"Loss value\")\n",
     "plt.subplot(122)\n",
     "plt.plot(step, distance_to_target)\n",
-    "plt.plot(step[mask], distance_to_target[mask], \"bo-\")\n",
+    "plt.plot(step[mask], distance_to_target[mask], \"bo\")\n",
     "plt.xlabel(\"Step\")\n",
     "plt.ylabel(\"Distance to target\")\n",
     "\n",

diff --git a/notebooks/metagrating_challenge.ipynb b/notebooks/metagrating_challenge.ipynb
@@ -90,7 +90,7 @@
     "plt.ylabel(\"Loss value\")\n",
     "plt.subplot(122)\n",
     "plt.plot(step, distance_to_target)\n",
-    "plt.plot(step[mask], distance_to_target[mask], \"bo-\")\n",
+    "plt.plot(step[mask], distance_to_target[mask], \"bo\")\n",
     "plt.xlabel(\"Step\")\n",
     "plt.ylabel(\"Distance to target\")\n",
     "\n",

diff --git a/notebooks/photon_extractor_challenge.ipynb b/notebooks/photon_extractor_challenge.ipynb
@@ -88,12 +88,22 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "# Plot the loss and efficiency vs. step.\n",
+    "# Plot the loss vs. step, and the `distance_to_target`. When the distance is\n",
+    "# zero or negative, the challenge is considered to be solved.\n",
     "step = onp.arange(len(loss_values))\n",
+    "distance_to_target = onp.asarray(distance_values)\n",
+    "mask = distance_to_target <= 0\n",
     "\n",
+    "plt.figure(figsize=(8, 4))\n",
+    "plt.subplot(121)\n",
     "plt.plot(step, loss_values)\n",
     "plt.xlabel(\"Step\")\n",
     "plt.ylabel(\"Loss value\")\n",
+    "plt.subplot(122)\n",
+    "plt.plot(step, distance_to_target)\n",
+    "plt.plot(step[mask], distance_to_target[mask], \"bo\")\n",
+    "plt.xlabel(\"Step\")\n",
+    "plt.ylabel(\"Distance to target\")\n",
     "\n",
     "plt.tight_layout()"
    ]
@@ -225,6 +235,14 @@
     "\n",
     "plt.tight_layout()"
    ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "b0bbe84b-fb49-4fad-8e11-020434312e3f",
+   "metadata": {},
+   "outputs": [],
+   "source": []
   }
  ],
  "metadata": {