Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SelectionList concept #8054

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

Conversation

matmair
Copy link
Member

@matmair matmair commented Sep 2, 2024

This PR adds the concept of SelectionLists - a way to define reusable choices for parameters (optionally controllable by plugins).

This is helpful to load and sync a list of choices into multiple instances. The usage of SelectionLists could be extended in the future.

Screenshots

CUI

grafik

grafik

grafik

PUI

grafik

grafik

grafik

grafik

ToDo:

  • PUI unit testing
  • locking SelectionList
  • list deactivation logic

@matmair matmair added enhancement This is an suggested enhancement or new feature api Relates to the API Platform UI Related to the React based User Interface labels Sep 2, 2024
@matmair matmair added this to the 0.17.0 milestone Sep 2, 2024
@matmair matmair self-assigned this Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit aed0417
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67432c18d1172d00081a464e

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 89.05109% with 30 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (e2e0ecc) to head (aed0417).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/forms/selectionListFields.tsx 19.04% 17 Missing ⚠️
...rontend/src/components/forms/fields/TableField.tsx 33.33% 6 Missing ⚠️
src/frontend/src/components/render/ModelType.tsx 0.00% 2 Missing ⚠️
src/frontend/src/forms/PartForms.tsx 60.00% 1 Missing and 1 partial ⚠️
...rc/frontend/src/tables/part/SelectionListTable.tsx 90.00% 2 Missing ⚠️
...end/src/pages/Index/Settings/AdminCenter/Index.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8054      +/-   ##
==========================================
+ Coverage   84.61%   84.63%   +0.02%     
==========================================
  Files        1178     1183       +5     
  Lines       53641    53908     +267     
  Branches     2026     2031       +5     
==========================================
+ Hits        45387    45627     +240     
- Misses       7730     7775      +45     
+ Partials      524      506      -18     
Flag Coverage Δ
backend 86.02% <100.00%> (+0.07%) ⬆️
migrations 42.66% <41.37%> (+0.04%) ⬆️
pui 69.16% <57.74%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SchrodingersGat
Copy link
Member

@matmair what's still to go on this one?

@matmair matmair marked this pull request as ready for review November 22, 2024 17:10
@matmair matmair closed this Nov 23, 2024
@matmair matmair reopened this Nov 23, 2024
@matmair matmair added the full-run Always do a full QC CI run label Nov 23, 2024
@matmair matmair closed this Nov 23, 2024
@matmair matmair reopened this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature full-run Always do a full QC CI run Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants