Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds "ON HOLD" status to order models #7807

Merged
merged 46 commits into from
Aug 7, 2024
Merged

Adds "ON HOLD" status to order models #7807

merged 46 commits into from
Aug 7, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Aug 4, 2024 •
edited
Loading

This PR adds the "ON HOLD" status type to existing order models, allowing orders to be marked as paused.

Features

  • Add to Build Order
  • Add to Purchase Order
  • Add to Sales Order
  • Add to Return Order
  • Implement state transition logic
  • Implement state transition controls to PUI
  • Adds a new useStatusCode hook which allows front-end code to access back-end enumeration values
  • Various optimizations

TODO

@SchrodingersGat
Add "ON_HOLD" status code for orders
da59fe6
@SchrodingersGat
Add placeholder buttons for purchase order status change
88553cf
@SchrodingersGat
Adds hooks for introspecting status code enumerations
9b951ac
@SchrodingersGat
Refactor status codes for import session
fafed9e 
- Remove hard-coded values
@SchrodingersGat
Refactor into <PrimaryActionButton />
68e8772
@SchrodingersGat
Cleanup
6018a4b
@SchrodingersGat
more permission checks
6d30b1e
@SchrodingersGat
Add placeholder actions for SalesOrder
1192344
@SchrodingersGat
Placeholder actions for ReturnOrder
8e074a6
@SchrodingersGat
Placeholder actions for build order
414e468
@SchrodingersGat
Actions for "return order"
99939e1
@SchrodingersGat
Update actions for return order
7b12865 
- Add "on hold" transition
@SchrodingersGat
Implement transitions for SalesOrder
6841952
@SchrodingersGat
Allow control over SalesOrderLineItemTable
7b35c9f
@SchrodingersGat
Implement PurchaseOrder actions
286cd09
@SchrodingersGat
Improve API query lookup efficiency
f10cc8e
@SchrodingersGat
UI cleanup
a3fa5a4
@SchrodingersGat
CUI cleanup
6e57a14
@SchrodingersGat
Build Order Updates
1f8d0ae 
- Implement StateTransitionMixin for BuildOrder model
- Add BuildIssue API endpoint
- Add BuildHold API endpoint
- API query improvements
- PUI actions
@SchrodingersGat
Increase timeout
f0c8c18
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders old user interface Issues with Old User interface api Relates to the API build Build orders refactor Platform UI Related to the React based User Interface labels Aug 4, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone Aug 4, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 4, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 67c9511
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66b31dbdf1c609000861c5ba

SchrodingersGat added a commit to inventree/demo-dataset that referenced this pull request Aug 5, 2024
@SchrodingersGat
Add more orders to dataset (#74)
0032952 
Ref: inventree/InvenTree#7807
@SchrodingersGat SchrodingersGat modified the milestones: 0.16.0, 0.17.0 Aug 7, 2024
@SchrodingersGat SchrodingersGat mentioned this pull request Aug 7, 2024
Merged
@SchrodingersGat SchrodingersGat mentioned this pull request Aug 7, 2024
Merged
@SchrodingersGat SchrodingersGat merged commit 0e8c297 into inventree:master Aug 7, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the order-hold branch August 7, 2024 10:34
@sentry-io Sentry.io
Copy link

sentry-io bot commented Aug 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'NoneType' object has no attribute 'schedule_pricing_update' /api/order/so/{pk}/complete/ View Issue

Did you find this useful? React with a 👍 or 👎

SchrodingersGat added a commit to SchrodingersGat/InvenTree that referenced this pull request Aug 14, 2024
@SchrodingersGat
Check before calling schedule_pricing_update
5c80354 
Ref: inventree#7807 (comment)
@SchrodingersGat SchrodingersGat mentioned this pull request Aug 14, 2024
Merged
SchrodingersGat added a commit that referenced this pull request Aug 14, 2024
@SchrodingersGat
Check before calling schedule_pricing_update (#7871)
697ab16 
Ref: #7807 (comment)
github-actions bot pushed a commit that referenced this pull request Aug 14, 2024
@SchrodingersGat
Check before calling schedule_pricing_update (#7871)
6f5db60 
Ref: #7807 (comment)
(cherry picked from commit 697ab16)
SchrodingersGat added a commit that referenced this pull request Aug 14, 2024
@github-actions @SchrodingersGat
Check before calling schedule_pricing_update (#7871) (#7872)
36ecd41 
Ref: #7807 (comment)
(cherry picked from commit 697ab16)

Co-authored-by: Oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair matmair left review comments

Assignees
No one assigned
Labels
api Relates to the API build Build orders enhancement This is an suggested enhancement or new feature feature old user interface Issues with Old User interface order Related to purchase orders / sales orders Platform UI Related to the React based User Interface refactor
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

[PUI] Implement status change buttons for orders Add "ON HOLD" status to orders
2 participants
@SchrodingersGat @matmair