Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: allowing search param key to be modified #243

Closed
wants to merge 1 commit into from

Conversation

0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Related to zenodo/zenodo-rdm#890

Makes the searchParamKey configurable to make it more accurate, previously it was set to suggest, which did not work well for certain endpoints e.g. api/awards

https://127.0.0.1:5000/api/awards?q=micro - returns 10 records containing the word micro in title
whereas, https://127.0.0.1:5000/api/awards?suggest=micro - returns 0 records
this would cause problems when users are searching for relevant results

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@0einstein0
Copy link
Member Author

Closed as we will introduce a separate component in the future that doesn't use the suggestion api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant