Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accordion can be folded on load #239

Merged

Conversation

Ducica
Copy link
Contributor

@Ducica Ducica commented May 9, 2024

❤️ Thank you for your contribution!

Description

Related to #236 and #230

Regarding the accordion made minimum changes so that it is foldable when the page loads. If you wish for it to be closed in the beginning use active={false} prop.

@Ducica
Copy link
Contributor Author

Ducica commented Jun 4, 2024

@ntarocco Hi Nicola, would it be possible for someone from your team to check out this PR and if it makes sense? Thank you

Copy link
Member

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR and sorry for the late review :) I added a couple of comments because we merge this!

src/lib/forms/AccordionField.js Show resolved Hide resolved
src/lib/forms/ArrayField.js Outdated Show resolved Hide resolved
src/lib/forms/ArrayField.js Outdated Show resolved Hide resolved
src/lib/forms/ArrayField.js Show resolved Hide resolved
fixed array field addButtonClassName
@Ducica Ducica force-pushed the issues-230-accordion-236-array-field branch from fa98384 to e1dcc27 Compare June 6, 2024 09:15
@Ducica
Copy link
Contributor Author

Ducica commented Jun 6, 2024

@zzacharo Zacharias, thanks a lot for your time. I've made the modifications per your comments. Have a good day

@zzacharo zzacharo merged commit 5dc7a6b into inveniosoftware:master Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants