Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ck editor with tiny mce #222

Merged

Conversation

0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Partially Closes Issue https://github.com/zenodo/rdm-project/issues/421

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@0einstein0 0einstein0 force-pushed the Replace-CkEditor-with-TinyMCE branch 3 times, most recently from a644d93 to 6feb0c0 Compare November 10, 2023 08:32
@0einstein0 0einstein0 force-pushed the Replace-CkEditor-with-TinyMCE branch from 6feb0c0 to d98087a Compare November 11, 2023 23:54
Copy link
Contributor

@kpsherva kpsherva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done, looks clean!
minor: please check the eslint warning

@0einstein0 0einstein0 force-pushed the Replace-CkEditor-with-TinyMCE branch from 3414cd5 to ee9376c Compare November 13, 2023 10:38
@0einstein0 0einstein0 force-pushed the Replace-CkEditor-with-TinyMCE branch from b2d2727 to f955e06 Compare November 16, 2023 16:05
@lnielsen lnielsen force-pushed the Replace-CkEditor-with-TinyMCE branch from 04ce4e3 to cfff366 Compare December 12, 2023 22:03
@lnielsen lnielsen merged commit 2c3b0b1 into inveniosoftware:master Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants