Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprint: ui serializer and missing fields #1305

Closed

Conversation

tmorrell
Copy link
Contributor

@tmorrell tmorrell commented May 11, 2023

❤️ Thank you for your contribution!

Description

This fixes a bug in the imprint formatting. When ISBN or place (not required fields) are missing, some extraneous formatting characters appear in the UI:

Screenshot 2023-05-11 at 4 40 08 PM

This fix borrows some ideas from the journal serializer to not render out non-required fields.

Screenshot 2023-05-11 at 4 53 03 PM

Screenshot 2023-05-11 at 4 55 20 PM

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@tmorrell tmorrell force-pushed the imprint-formatting branch from 32329e5 to f8e76f6 Compare June 21, 2023 23:36
@tmorrell
Copy link
Contributor Author

tmorrell commented Jun 21, 2023

We also noticed that the imprint serializer was missing the title and ISBN fields, so they never displayed on the landing page. I've modified this PR to display those as well, working off an approximate Chicago style.

Screenshot 2023-06-21 at 4 39 58 PM
Screenshot 2023-06-21 at 4 40 25 PM
Screenshot 2023-06-21 at 4 40 46 PM
Screenshot 2023-06-21 at 4 41 13 PM
Screenshot 2023-06-21 at 4 41 38 PM

@github-actions
Copy link
Contributor

This PR was automatically marked as stale.

@lnielsen
Copy link
Member

Merged as part of #1524

@lnielsen lnielsen closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released | Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants