Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

views: fix boolean logic for checking remote app visibility #335

Merged
merged 2 commits into from
Sep 17, 2024
Merged

views: fix boolean logic for checking remote app visibility #335

merged 2 commits into from
Sep 17, 2024

Conversation

max-moser
Copy link
Contributor

Previously, the logic did the opposite of what it was supposed to do: It filtered for the invisible remote apps

rekt-hard
rekt-hard approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@rekt-hard rekt-hard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for catching that

@max-moser max-moser merged commit bc0e068 into inveniosoftware:master Sep 17, 2024
2 checks passed
@max-moser max-moser deleted the mm/visible-remote-apps branch September 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekt-hard rekt-hard rekt-hard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-moser @rekt-hard