Models: Domain statistics and model change history tracking fixes #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes an issue where a newly uncommitted user would not yet have an id assigned, and hence would cause None value to be added to a list of user ids that needed to be reindexed, causing the indexing to fail due to transaction rollback.
* Adds a task to efficiently updates the domain statistics on a regular basis.
lnielsen
commented
Feb 12, 2024
| @@ -19,14 +23,46 @@ | |||
| class SessionAwareSQLAlchemyUserDatastore(SQLAlchemyUserDatastore): | |||
| """Datastore which deletes active session when a user is deactivated.""" | |||
|
|
|||
| def verify_user(self, user): | |||
There was a problem hiding this comment.
Moved here from Invenio-users-resources to treat these action consistently.
lnielsen
commented
Feb 12, 2024
| user.blocked_at = None | ||
| if user.confirmed_at is None: | ||
| user.confirmed_at = datetime.utcnow() | ||
| user_confirmed.send(current_app._get_current_object(), user=user) |
There was a problem hiding this comment.
Needs to send signal to run the code which takes care of registering the domain.
lnielsen
commented
Feb 12, 2024
| @@ -37,29 +73,39 @@ def commit(self): | |||
| datastore_post_commit.send(session=self.db.session) | |||
| current_db_change_history.clear_dirty_sets(self.db.session) | |||
|
|
|||
| def put(self, model): | |||
There was a problem hiding this comment.
Put was being used for both roles and users, but the mark_changed() call only handled users, and in addition the model object only have an id if it was committed which is not always the case.
Samk13
reviewed
Feb 13, 2024
Samk13
reviewed
Feb 13, 2024
kpsherva
reviewed
Feb 14, 2024
kpsherva
reviewed
Feb 15, 2024
lnielsen
force-pushed
the
fix-changehistory
branch
from
a6317cb to
eeb7203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: