model: avoid setting value on getter

* closes zenodo/rdm-project#521
inveniosoftware · Nov 9, 2023 · 60a0094 · 60a0094
1 parent 05657e0
commit 60a0094
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/invenio_accounts/models.py b/invenio_accounts/models.py
@@ -239,7 +239,7 @@ def preferences(self):
         if self._preferences is None:
             return None
         elif not isinstance(self._preferences, UserPreferenceDict):
-            self._preferences = UserPreferenceDict(**self._preferences)
+            return UserPreferenceDict(**self._preferences)
 
         return self._preferences