-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: add migration page #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great and very clear!
On a separate note, since we're hosting the images are there any ratelimits on our side at the CERN registry? Should we also recommend that people should look into having registry proxy/caches?
There are limitations at the moment. At the same time, I agree with you, I would not advertise this, and I would suggest having a proxy. I will add a line ;) Thanks! |
3e0004d
to
d57fbd1
Compare
I will make some changes to avoid switching to AlmaLinux, but use the CERN registry instead also for old images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is really helpful.
The change to almalinux actually incurs a change in the minimum version of docker that InvenioRDM supports. We discovered this the hard way: inveniosoftware/docker-invenio#75 . The system requirements should be updated to something like:
- [Docker](https://docs.docker.com) 20.10.10+
(some kind of InvenioRDM version indicator would help in the future)
(docker uses sort-of calver now)
Overall, these docs are also the kind of thing that is worth proselytizing on discord / blog post, so that more community members are aware of them before things suddenly stop working.
There are some news: https://www.docker.com/blog/we-apologize-we-did-a-terrible-job-announcing-the-end-of-docker-free-teams/ |
d57fbd1
to
1c5828b
Compare
I have updated the doc page, mainly rephrasing the text from
Thanks for this, added.
Just for me to be sure that I have correctly understood, do you propose changing the future version numbers of InvenioRDM (v9, v10, ...) to use a CalVer?
This makes sense indeed: the current plan is to add it to the doc, announce it at the telecon + chat. |
1c5828b
to
981b44b
Compare
For this
I meant: As InvenioRDM accumulates versions with different features, it can become hard for documentation readers to understand which version of InvenioRDM is relevant to the documentation they are reading e.g., v11 of InvenioRDM requires Docker 20.10.10+ but v9 didn't. The problem of how to convey that is something to look into again in the future. We already have the ticket: #44 but as explained there the attempt has fell through. Another way than what was attempted in the ticket would be to textually write it in (a-la python docs) by adding in situ New in version vX.Y., or Changed in version vX.Y: phlogiston now boombazzles or so on... Nothing specific to do for now, but raise importance of that ticket. For this
It was just to highlight how we can look at docker's version number to know how old the version of it is (soft of since 20.10.10 came out in 2021-10. Although when I think about it, it actually makes sense since it was a patched release). This is something to keep in mind since Docker doesn't do LTS in practice (their time frames are way too short). Nothing to do there either - just informative. |
We are already doing this, see for example here. It would be nice indeed to have the doc versioned. |
New section under "upgrade guide":