Add 'python_version' to cookiecutter config variables #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandromumo
changed the title
slint
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
LGTM!
For the commit message "style", also have a look at the Style guide. I think "topic" here is the catch-all general...
* Variable 'python_version' was missing from 'cookiecutter.json' and 'Pipfile'. When scaffolding the module, it was impossible to set a python version on which the instance would run (e.g. when creating a virtual environment) * Adds variable 'python_version' to 'cookiecutter.json' and 'Pipfile' * Adds documentation for variable 'python_version'
alejandromumo
force-pushed
the
insert-python-version-cookiecutter
branch
from
3022aca to
818ca44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull requests adds
python_versionconfig variable to cookiecutter.