Mark allocation tests broken in julia 1.4 #117
Conversation
test/name_operations.jl
Outdated
| using SparseArrays | ||
|
|
There was a problem hiding this comment.
I don't think this is enough to make this able to run stand-alone.
since it also would need using NamedDims and using Test at least.
In general to run a subset of tests, easiest is to comment out the includes in runtests.jl as that means test-time dependencies still get installed.
| using SparseArrays |
There was a problem hiding this comment.
Though this package does seem to try to make files able to run stand alone
So maybe better to finish the job:
| using SparseArrays | |
| using NamedDims | |
| using SparseArrays | |
| using Test |
There was a problem hiding this comment.
Ah, sorry, I didn't express myself clearly: What I meant was to comment out the other includes as you say.
I guess best practice would be to put the using SparseArrays to the runtests.jl? And in this case do you suggest above in order to allow running include("test/wrapper_array.jl")?
There was a problem hiding this comment.
I guess best practice would be to put the using SparseArrays to the runtests.jl
Yes
And in this case do you suggest above in order to allow running include("test/wrapper_array.jl")?
Probably not but you can.
This package is still doing it in many places so you can do that, but it is a bit of an aberation and shouldn't be.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 9 9
Lines 311 311
=======================================
Hits 277 277
Misses 34 34 Continue to review full report at Codecov.
|
Relates to tests in #115 .
The
using SparseArraysmakes sure the tests inname_operations.jlcan run standalone. Sorry for including it here, added this commit earlier and it slipped in here.