Skip to content

Commit

Permalink
Bump various package dependencies and update to Tables 1.0.
Browse files Browse the repository at this point in the history
  • Loading branch information
rofinn committed Feb 26, 2020
1 parent 4546b9a commit 6994383
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
8 changes: 4 additions & 4 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"
TableOperations = "ab02a1b2-a7df-11e8-156e-fb1833f50b87"
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"

[compat]
DataFrames = ">= 0.16"
IterTools = "1.2"
RDatasets = ">= 0.6.2"
IterTools = "1.2, 1.3"
StatsBase = "0.32"
Tables = "0.2"
TableOperations = "0.2"
Tables = "1"
julia = "1"

[extras]
Expand Down
1 change: 1 addition & 0 deletions src/Impute.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ using IterTools
using Random
using Statistics
using StatsBase
using TableOperations
using Tables: Tables, materializer, istable

using Base.Iterators
Expand Down
2 changes: 1 addition & 1 deletion src/imputors/drop.jl
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function impute(table, imp::DropVars)
!ismissing!(c, getproperty(cols, cname))
end

selected = Tables.select(table, cnames...)
selected = TableOperations.select(table, cnames...)
table = materializer(table)(selected)
return table
end
Expand Down
5 changes: 3 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ using RDatasets
using Random
using Statistics
using StatsBase
using TableOperations
using Tables
using Test

Expand Down Expand Up @@ -207,7 +208,7 @@ end
coltab = Tables.columntable(table)

result = impute(coltab, DropVars(; context=ctx))
expected = Tables.columntable(Tables.select(coltab, :cos))
expected = Tables.columntable(TableOperations.select(coltab, :cos))

@test isequal(result, expected)
@test isequal(result, Impute.dropvars(coltab; context=ctx))
Expand All @@ -221,7 +222,7 @@ end
@testset "Row Table" begin
rowtab = Tables.rowtable(table)
result = impute(rowtab, DropVars(; context=ctx))
expected = Tables.rowtable(Tables.select(rowtab, :cos))
expected = Tables.rowtable(TableOperations.select(rowtab, :cos))

@test isequal(result, expected)
@test isequal(result, Impute.dropvars(rowtab; context=ctx))
Expand Down

0 comments on commit 6994383

Please sign in to comment.