Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix position list pagination bugs #571

Merged
merged 11 commits into from
Jan 31, 2024
Merged

fix position list pagination bugs #571

merged 11 commits into from
Jan 31, 2024

Conversation

zielvna
Copy link
Collaborator

@zielvna zielvna commented Jan 26, 2024

No description provided.

Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an issue. Here is how to reproduce it:

  1. I am on the 2nd page of the position list in the Invarinat app, connected to wallet A.
  2. I disconnect wallet A in the Invariant app.
  3. I change the wallet in the wallet extension to wallet B.
  4. I click "connect wallet" in the Invarinat app to connect wallet B. There is only one position here (everything is still working fine).
  5. I disconnect wallet B in the Invariant app.
  6. I click "connect wallet" in the Invarinat app to connect wallet A. Now, the issue occurs:
    I get a view where the position list is on page 1, but in the pagination navigation, page 2 is currently highlighted. This means there is an inconsistency between the highlighted page and the displayed positions in the position list

Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, there is a problem with the previous bug. When I remove the last position on the second page

@wojciech-cichocki
Copy link
Member

Now, there is a problem with the previous bug. When I remove the last position on the second page

Here's the screen:
image

Copy link

This pull request has been deployed to Vercel.

Latest commit: 2aa1b95
✅ Preview: https://webapp-isbyaqky9-invariantlabs.vercel.app
🔍 Inspect: https://vercel.com/invariantlabs/webapp/Bxh5gTUd5pG2aR4fneVUaJA57Fcp

View Workflow Logs

@zielvna zielvna changed the base branch from master to dev January 30, 2024 18:05
@wojciech-cichocki wojciech-cichocki merged commit 5c27528 into dev Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants