Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ref id to risk scenario #1078

Merged
merged 16 commits into from
Nov 23, 2024
Merged

Conversation

melinoix
Copy link
Contributor

added ref id to risk scenario to replace hidden R.id (Kept on migration by putting each R.id in ref_id.

backend/core/views.py Fixed Show fixed Hide fixed
@eric-intuitem
Copy link
Collaborator

The ref_id shall be editable.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to see the ref_id field, and to edit it, like the name field. It is only pre-filled with R.x.

nas-tabchiche and others added 4 commits November 23, 2024 17:23
This allows posting a risk scenario with an empty ref_id using the API to set its value to default.
Ref ID max length is now 8
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 2bcae06 into main Nov 23, 2024
20 checks passed
@eric-intuitem eric-intuitem deleted the CA-625-add-ref-id-to-risk-scenario branch November 23, 2024 23:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants