Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript definitions to match the latest SDK v3.0.2 #106

Merged
merged 3 commits into from
Nov 8, 2020

Conversation

shlok-kothari
Copy link

@shlok-kothari shlok-kothari marked this pull request as draft October 26, 2020 03:22
@@ -86,6 +88,8 @@ declare namespace OAuthClient {
clientSecret: string;
redirectUri?: string;
environment?: string;
token: Token;
logging: boolean;
}

export enum environment {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OAuthClient.migrate_production = 'https://developer.api.intuit.com/v2/oauth2/tokens/migrate';

I wasn't sure if constants such as these also had to be included in this file? Lines 79-109 from OAuthClient.js..I did see some constants like the scopes and environment already defined so wanted to clarify

@shlok-kothari
Copy link
Author

shlok-kothari commented Oct 26, 2020

Screen Shot 2020-10-25 at 10 27 23 PM

I'm unable to run the sample app, for some reason `req.query.json.clientId` is not being treated as a property of a JSON object, though I did verify that `typeof(req.query.json)` is object. I tried `JSON.parse(req.query.json.toString()).clientId` but that gives me a different error: `SyntaxError: Unexpected token o in JSON at position 1`

@abisalehalliprasan I had a couple of questions, this is my first time working with typescript so I'm sorry if it was something obvious!

@abisalehalliprasan abisalehalliprasan marked this pull request as ready for review November 8, 2020 17:27
@abisalehalliprasan
Copy link
Collaborator

Thanks @shlok-kothari. I will take a look at the PR 👍

@abisalehalliprasan abisalehalliprasan merged commit 6d3d141 into intuit:typescript Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants