Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect noVersionPrefix option in the Version File plugin #2472

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

KetanReddy
Copy link
Collaborator

What Changed

Previously during a non-canary/next release, the version file plugin would always prepend a v to the tag that was created for the new version regardless of if the noVersionPrefix option was set.

Why

The noVersionPrefix option should be respected

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Aug 21, 2024
@KetanReddy KetanReddy marked this pull request as ready for review August 21, 2024 00:38
@adierkens adierkens merged commit 52799a0 into intuit:main Aug 28, 2024
5 of 7 checks passed
Copy link

🚀 PR was released in v11.2.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants