Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra quotes surrounding commitMessage #2445

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: remove extra quotes surrounding commitMessage #2445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeb577a
fix: remove extra quotes surrounding commitMessage
UpstartMPotnick Mar 19, 2024
b44b40e
test: update test
UpstartMPotnick Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions plugins/npm/__tests__/npm.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
"'\"Bump version to: %s [skip ci]\"'",
"\"Bump version to: %s [skip ci]\"",
false,
]);
});
Expand Down Expand Up @@ -645,7 +645,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
"'\"Bump version to: %s [skip ci]\"'",
"\"Bump version to: %s [skip ci]\"",
false,
]);
});
Expand Down Expand Up @@ -674,7 +674,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
"'\"Bump version to: %s [skip ci]\"'",
"\"Bump version to: %s [skip ci]\"",
"--exact",
]);

Expand Down Expand Up @@ -881,7 +881,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
"'\"Bump version to: %s [skip ci]\"'",
"\"Bump version to: %s [skip ci]\"",
false,
]);
});
Expand Down Expand Up @@ -924,7 +924,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
"'\"[skip ci] Custom version commit message\"'",
"\"[skip ci] Custom version commit message\"",
false,
]);
});
Expand Down Expand Up @@ -967,7 +967,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
"'\"Custom version commit message [skip ci]\"'",
"\"Custom version commit message [skip ci]\"",
false,
]);
});
Expand Down Expand Up @@ -1529,7 +1529,7 @@ describe("canary", () => {
"--yes",
"--no-push",
"-m",
`'"Bump independent versions [skip ci]"'`,
"\"Bump independent versions [skip ci]\"",
false,
]);
});
Expand Down
2 changes: 1 addition & 1 deletion plugins/npm/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,7 @@ export default class NPMPlugin implements IPlugin {
"--yes",
"--no-push",
"-m",
`'"${commitMessage}"'`,
`"${commitMessage}"`,
this.exact && "--exact",
...verboseArgs,
]);
Expand Down
Loading