Merge pull request #99 from hipstersmoothie/non-required-args

url isn't required for pr or pr-check
intuit · Dec 18, 2018 · fcc94fa · fcc94fa
2 parents cf8e4bc + e395418
commit fcc94fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/docs/pages/auto-pr-check.md b/docs/pages/auto-pr-check.md
@@ -14,7 +14,7 @@ auto pr-check --pr 24 --url http://your-ci.com
 Options
 
   --pr number [required]           The pull request number you want the labels of
-  --url string [required]          URL to associate with this status
+  --url string                     URL to associate with this status
   --onlyPublishWithReleaseLabel    Only bump version if 'release' label is on pull request
   --major string                   The name of the tag for a major version bump
   --minor string                   The name of the tag for a minor version bump

diff --git a/docs/pages/auto-pr.md b/docs/pages/auto-pr.md
@@ -12,7 +12,7 @@ Options
   --sha string                      Specify a custom git sha. Defaults to the HEAD for a git repo in the current
                                     repository
   --pr number [required]            The pull request number you want the labels of
-  --url string [required]           URL to associate with this status
+  --url string                      URL to associate with this status
   --state string [required]         State of the PR. ['pending', 'success', 'error', 'failure']
   --description string [required]   A description of the status
   --context string [required]       A string label to differentiate this status from others

diff --git a/src/cli/args.ts b/src/cli/args.ts
@@ -220,7 +220,7 @@ const commands: ICommand[] = [
   {
     name: 'pr-check',
     summary: 'Check that a pull request has a SemVer label',
-    require: ['pr', 'url'],
+    require: ['pr'],
     options: [
       pr,
       url,
@@ -239,7 +239,7 @@ const commands: ICommand[] = [
   {
     name: 'pr',
     summary: 'Set the status on a PR commit',
-    require: ['pr', 'state', 'description', 'context', 'url'],
+    require: ['pr', 'state', 'description', 'context'],
     options: [
       {
         name: 'sha',
@@ -272,7 +272,7 @@ const commands: ICommand[] = [
       ...defaultOptions
     ],
     examples: [
-      `{green $} auto pr \\\\ \n   --pr 32 \\\\ \n   --url http://your-ci.com/build/123 \\\\ \n   --state pending \\\\ \n   --description "Build still running..." \\\\ \n   --context build-check`
+      `{green $} auto pr \\\\ \n   --pr 32 \\\\ \n   --state pending \\\\ \n   --description "Build still running..." \\\\ \n   --context build-check`
     ]
   },
   {