Merge pull request #2478 from intuit/mandrew/private

private packages should be included in changelogs
intuit · Oct 25, 2024 · 7948e45 · 7948e45
2 parents be95283 + ff07eb5
commit 7948e45
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/packages/core/src/utils/__tests__/get-lerna-packages.test.ts b/packages/core/src/utils/__tests__/get-lerna-packages.test.ts
@@ -20,17 +20,3 @@ test("it shouldn't included version-less packages", async () => {
     },
   ]);
 });
-
-test("it shouldn't included private packages", async () => {
-  exec.mockReturnValue(endent`
-    /dir/a:a:0.3.0--canary.32.d54a0c4.0
-    /dir/b:b:0.3.0:PRIVATE
-  `);
-  expect(await getLernaPackages()).toStrictEqual([
-    {
-      name: "a",
-      path: "/dir/a",
-      version: "0.3.0--canary.32.d54a0c4.0",
-    },
-  ]);
-});
diff --git a/packages/core/src/utils/get-lerna-packages.ts b/packages/core/src/utils/get-lerna-packages.ts
@@ -15,9 +15,9 @@ export default async function getLernaPackages() {
   const response = await execPromise("npx", ["lerna", "ls", "-pla"]);
 
   response.split("\n").forEach((packageInfo) => {
-    const [packagePath, name, version, isPrivate] = packageInfo.split(":");
+    const [packagePath, name, version] = packageInfo.split(":");
 
-    if (version !== "MISSING" && isPrivate !== "PRIVATE") {
+    if (version !== "MISSING") {
       packages.push({ path: packagePath, name, version });
     }
   });